New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/Formula-Cookbook: add more details to tests #6169

Merged

MikeMcQuaid merged 1 commit into Homebrew:master from Moisan:doc_tests_details

May 24, 2019

Member

Moisan commented May 24, 2019

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same change?
Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes? Here's an example.
Have you successfully run brew style with your changes locally?
Have you successfully run brew tests with your changes locally?

@fxcoudert made some good comments on writing tests in this PR. I think we can improve the documentation with them. I also added a couple examples.


          docs/Formula-Cookbook: add more details to tests

7a8a3a3

MikeMcQuaid approved these changes

View reviewed changes

Member

MikeMcQuaid commented May 24, 2019

Thanks both of you!

MikeMcQuaid merged commit 11b24b3 into Homebrew:master

Moisan deleted the doc_tests_details branch

May 24, 2019 13:22

lock bot added the outdated label

lock bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.